On Sat, May 01 2021, David Bremner wrote:
> Felipe Contreras <felipe.contre...@gmail.com> writes:
>
>> The current tests fail on my machine due to my configuration, mainly because
>> I didn't have dtach
>> installed, but also other stuff.
>>
>> The following patches fix all the issues I found, and also do plenty of
>> cleanups.
>
> I have applied 1,2,4,5,6,7 to master. 10, 11, and 12 are also marked
> ready to apply, but currently don't because of skipped patches.
Good progress !
Now in the morning, after good night's sleep, I think of the following:
The following changes could be done (in 2 or 3 (3 for consistency) places):
--- a/test/T590-libconfig.sh
+++ b/test/T590-libconfig.sh
@@ -375,18 +375,19 @@ test_begin_subtest "load default values"
export MAILDIR=${MAIL_DIR}
cat c_head - c_tail <<'EOF' | test_C ${MAIL_DIR} '' %NULL%
{
notmuch_config_key_t key;
for (key = NOTMUCH_CONFIG_FIRST;
key < NOTMUCH_CONFIG_LAST;
key = (notmuch_config_key_t)(key + 1)) {
const char *val = notmuch_config_get (db, key);
printf("%s\n", val ? val : "NULL" );
+ printf("%s = %s\n", key, val ? val : "NULL" );
}
}
EOF
Then, update the EXPECTED strings.
Finally, move the notmuch_passwd_sanitize () from lib to
T590-libconfig.sh (perhaps rename to more "specialized"
name) and change it to first match key before replacing
the value in the c program output (and replace to empty
strings, too!).
I am soon going somewhere, I'll look this in the evening
in (+0300 timezone) unless someone(tm) is faster there...
>
> d
Tomi
_______________________________________________
notmuch mailing list -- notmuch@notmuchmail.org
To unsubscribe send an email to notmuch-le...@notmuchmail.org
