Floris Bruynooghe <f...@devork.be> writes: > oh, nice debugging! And yes, this seems like the right fix, glad the > mechanism was at least already in place. > > With respect to the docs, they seem clear enough. Probably I missed > this or I simply didn't realise that the replies iter is basically a > thread owning it. >
Thanks for the review. > Only thing I'd do different is write a pytest test for this as well, but > than I wouldn't have written the notmuch tests. So I don't think this > matters that much. We can always add a pytest test later. One thing I would like to think about is the length of time it takes to run the pytests. It is not currently the bottleneck in running the parallel tests for me, but it is among the slower T*.sh. So it might be nice at some point to split into several invocations for pytest, assuming multiple invocations of pytest can run in parallel. d _______________________________________________ notmuch mailing list -- notmuch@notmuchmail.org To unsubscribe send an email to notmuch-le...@notmuchmail.org