On Wed, Feb 16 2022, Michael J. Gruber wrote: > David Bremner venit, vidit, dixit 2022-02-16 14:04:17: >> Michael J Gruber <g...@grubix.eu> writes: >> >> > Some build infrastructure appears to habe problems with mtime/stat, >> >> have > > Huh, this looks as if my mother tongue slipped in, while it's just key > proximity. > >> > leading to spurious failures (noticed on s390x and aarch64 with epel8). >> > Allow the test suite to be run with --full-sync so that release builds >> > can use the test suite while avoiding spurious failures. >> > >> > Signed-off-by: Michael J Gruber <g...@grubix.eu> >> > --- >> > test/README | 8 ++++++++ >> > test/test-lib-common.sh | 7 ++++++- >> > test/test-lib.sh | 2 +- >> > 3 files changed, 15 insertions(+), 2 deletions(-) >> > >> > diff --git a/test/README b/test/README >> > index 10f127cb..1de79b78 100644 >> > --- a/test/README >> > +++ b/test/README >> > @@ -110,6 +110,14 @@ printed on screen. This printing can be disabled by >> > setting the >> > NOTMUCH_TEST_QUIET variable to a non-null value. Message on test >> > failures and skips are still printed. >> >> typo in variable name. > > Not here, but in fact in the actual patch ;) > > >> How confident are you that this actually fixes your intermittent >> failures? There are quite a few literal invocations of "notmuch new" in >> the test suite. Would those need to be changed as well? > > About 80% confident ... The patch covers all areas in which I've ever > witnessed the spurious FAILs. I have not had a single failure with the > patch. Many of the other invocations are not immediately after message > creation. > > Some of them are immediately after, and - given that notmuch new catches > the case of same time - I do not understand why this happens at all. > That accounts for the other 20%. > > I don't mind carrying this locally and retrying without for the next > round of notmuch updates. Having the patch here on-list may help > someone else in the future in any case.
I'd not merge this NOTMUCH_NEW_OPTIONS=--full-scan ;D too eagerly ... I'd like we really knew the reason (which is then written in commit message) > > Michael Tomi _______________________________________________ notmuch mailing list -- notmuch@notmuchmail.org To unsubscribe send an email to notmuch-le...@notmuchmail.org