jao <j...@gnu.org> writes: >> >> As mentioned in my previous reply, I'm still not 100% clear on why we >> need both depth and level. > > i might be misremembering, but i think depth is just an auxiliarly > argument taken by that function to know whether it's inserting the tip > of a tree or not, not a real depth. level is. so a better way would be > to make 'depth' take the values 'level' is currently taking, but i > wasn't sure other code would be using depth with its old original > meaning (e.g. via and advice; i did at some point). >
depth is used for indentation in notmuch-show-mode, so it should be (close to) what you want? There is already a function notmuch-show-get-depth. > >> >>> + (buffer-name notmuch-tree-message-buffer)))) >> >> At first glance, depending on the buffer name seems fragile? > > not sure why, or how to make it more robust... It depends on the buffer being named after the message-id. If I understand the current code correctly, this depends on the default naming in notmuch show, but that could change e.g. like it did for notmuch-search. OTOH, I guess I don't really understand what this is checking for, since I was using something based on #'notmuch-tree-get-message-properties _______________________________________________ notmuch mailing list -- notmuch@notmuchmail.org To unsubscribe send an email to notmuch-le...@notmuchmail.org
