Kristoffer Balintona <[email protected]> writes: > Hello,
Hello! > The current behavior of notmuch accords with the user values of below > and traditional but not above. > > The notmuch function responsible for the position of the signature > (or, rather, the position of the citations) is notmuch-mua-reply. I > have attached a patch that adds a brief snippet which obeys > message-cite-reply-position when its value is above. This indeed seems reasonable. Thank you! I am not a maintainer, but here are some comments of mine. > diff --git a/emacs/notmuch-mua.el b/emacs/notmuch-mua.el > index bf62b656..1d1a1591 100644 > --- a/emacs/notmuch-mua.el > +++ b/emacs/notmuch-mua.el > @@ -295,6 +295,20 @@ Typically this is added to `notmuch-mua-send-hook'." > (when message-signature-insert-empty-line > (forward-line -1)) > (goto-char (point-max)))) > + ;; If `message-cite-reply-position' is `above', e.g., for Gmail-like > + ;; email replies, then before inserting the citation, put the point > + ;; after the signature and insert a newline for spacing. Also respects > + ;; if `message-cite-reply-position' is set via `message-cite-style'. > + (when (or (equal message-cite-reply-position 'above) Nit: I think it is slightly better to use 'eq' instead of 'equal' here. > + (and message-cite-style > + (eq (eval (cadr > + (assoc 'message-cite-reply-position Likewise, here we may use 'assq'. > + (if (symbolp message-cite-style) > + (eval message-cite-style) Here I think it is better to use 'symbol-value' instead of 'eval'. > + message-cite-style)))) > + 'above))) > + (goto-char (point-max)) > + (insert "\n")) > (let ((from (plist-get original-headers :From)) > (date (plist-get original-headers :Date)) > (start (point))) Regards, Pengji _______________________________________________ notmuch mailing list -- [email protected] To unsubscribe send an email to [email protected]
