[email protected] writes: > Hello, > > It's quite common nowadays for Emacs users to use `setq` to set values > for custom, but doing that with notmuch-search-oldest-first it > gets overwritten currently in #'notmuch-search. > > I'm attaching a patch that modifies the code to retain the existing > value by using a conditional `and`. >
Thanks for taking the time to send a patch. Unfortunately this approach breaks other uses of the variable. In particular at least #'notmuch-search-toggle-order is broken by this change (see [1] for a test). The rest of this message is just some hints to reduce the number of round trips for future contributions. You can skip it if that isn't relevant. For future reference, we'd prefer [2] more verbose commit messages. A change like this would also need documentation changes (we have a least one more user visible buffer local variable, so would need to explain the difference). Since as you see the situation with maintaining UI state is a bit fragile, one or more tests to illustrate the intended behaviour change would helpful. Of course all this is a bit heavyweight, and it makes sense to discuss a prototype patch, although even that discussion is helped by more detail. [1]: https://nmbug.notmuchmail.org/nmweb/show/20260121133929.1522581-1-david%40tethera.net [2]: https://notmuchmail.org/contributing/ _______________________________________________ notmuch mailing list -- [email protected] To unsubscribe send an email to [email protected]
