On Fri, May 28, 2010 at 11:45:17AM -0700, Aaron Plattner wrote: > On Sun, May 23, 2010 at 03:37:03PM -0700, Ben Skeggs wrote: > > On Sun, 2010-05-23 at 21:46 +0200, Marcin Slusarz wrote: > > > 1) DRICreatePCIBusID belongs to xserver dri module, so when it's > > > unavailable we can't format string for drmCheckModesettingSupported. > > > (This situation happened to me with KMS enabled and dri module moved > > > somewhere else by Gentoo's "eselect opengl set nvidia" switcher) > > > Open code DRICreatePCIBusID to drop dri dependency. > > > 2) Once we dropped dependency on dri module (which linked to libdrm), > > > we have to link directly to libdrm. > > An alternative, which we use in Fedora for nv/vesa is to use > > pci_device_has_kernel_driver() from libpciaccess. > > That seems better than open-coding it, and avoids a dependency on libdrm > which is nice.
Well, you are trading one dependency for other. It doesn't really matter... Ben, are you going to send your patch to Aaron? Marcin _______________________________________________ Nouveau mailing list Nouveau@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/nouveau