https://bugs.freedesktop.org/show_bug.cgi?id=80901
--- Comment #13 from Martin Peres <martin.pe...@ensi-bourges.fr> --- Comment on attachment 102433 --> https://bugs.freedesktop.org/attachment.cgi?id=102433 PATCH: add LINEAR_MIN and LINEAR_MAX to sysfs Thanks, this patch is perfectly sound! However, it doesn't follow the sysfs interface of hwmon as defined here: https://www.kernel.org/doc/Documentation/hwmon/sysfs-interface I don't particularly like this interface, but I've tried to stay as close to it as possible. One possibility could be to use the trip points to expose linear_min/max, however, we would be bending the definition of trip point by a long shot (we are not supposed to scale linearly between trip points, at least that's how NVIDIA defines trip points, that's a question worth asking to the hwmon guys). If we are to keep your patch more or less intact, you would have to move your the end result to nouveau_sysfs.c. You would also need to change the name to temp1_fan_linear_min/max, to improve the clarity of what values are expected in there :) Finally, you would need to update the documentation (http://cgit.freedesktop.org/nouveau/linux-2.6/tree/Documentation/thermal/nouveau_thermal). Thanks again for your interest in fixing this! -- You are receiving this mail because: You are the assignee for the bug.
_______________________________________________ Nouveau mailing list Nouveau@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/nouveau