Hey Karol,

Until you can convince me that this (pending) progress-in-insight[1] is accounted for in the way nouveau configures the clock registers, I must NACK this patch.
Sorry.

Roy

[1] "nvkm/clk/gf100: Read secondary bypass postdiv when required" - currently on https://github.com/RSpliet/kernel-nouveau-nv50-pm/commit/d230af49bd0e25271161a9622337b01443214ec0

Op 13-01-16 om 12:25 schreef Karol Herbst:
this gives me on my 630M fermi card some speed improvements while on 0f:

pixmark_piano: ~800ms to ~500ms frame time
unigine_heaven (lowest setting, fullhd): 5.1 fps to 6.4 fps)

clocks for this gpu:
07: 270 MHz
0f: 475 MHz

Signed-off-by: Karol Herbst <nouv...@karolherbst.de>
---
  drm/nouveau/nvkm/subdev/clk/gf100.c | 2 +-
  1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drm/nouveau/nvkm/subdev/clk/gf100.c 
b/drm/nouveau/nvkm/subdev/clk/gf100.c
index ad93350..2ce902f 100644
--- a/drm/nouveau/nvkm/subdev/clk/gf100.c
+++ b/drm/nouveau/nvkm/subdev/clk/gf100.c
@@ -535,6 +535,6 @@ gf100_clk_new(struct nvkm_device *device, int index, struct 
nvkm_clk **pclk)
                return -ENOMEM;
        *pclk = &clk->base;
- return nvkm_clk_ctor(&gf100_clk, device, index, false, false,
+       return nvkm_clk_ctor(&gf100_clk, device, index, true, false,
                             &clk->base);
  }

_______________________________________________
Nouveau mailing list
Nouveau@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/nouveau

Reply via email to