On Thu, Mar 16, 2023 at 03:31:22PM +0100, Karol Herbst wrote:
> Users kept complaining about those messages and it's a little spammy on
> prime systems so turn it into a debug print.
>
> Cc: Bjorn Helgaas <bhelg...@google.com>
> Cc: Lukas Wunner <lu...@wunner.de>
> Cc: linux-...@vger.kernel.org
> Cc: nouveau@lists.freedesktop.org
> Fixes: b516ea586d71 ("PCI: Enable NVIDIA HDA controllers")
> Signed-off-by: Karol Herbst <kher...@redhat.com>
Could you provide Link: tags to bugzillas or mailing list messages
of those complaints so that the sentence sounds a little less like
hand-waving?
The point of the message is that if users see adverse effects as a
result of exposing the hidden HDA controller, they get a hint in
dmesg as to the cause. Hopefully the existence of such adverse
effects can be ruled out by now.
Thanks,
Lukas
> ---
> drivers/pci/quirks.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/pci/quirks.c b/drivers/pci/quirks.c
> index 44cab813bf951..b10c77bbe4716 100644
> --- a/drivers/pci/quirks.c
> +++ b/drivers/pci/quirks.c
> @@ -5549,7 +5549,7 @@ static void quirk_nvidia_hda(struct pci_dev *gpu)
> if (val & BIT(25))
> return;
>
> - pci_info(gpu, "Enabling HDA controller\n");
> + pci_dbg(gpu, "Enabling HDA controller\n");
> pci_write_config_dword(gpu, 0x488, val | BIT(25));
>
> /* The GPU becomes a multi-function device when the HDA is enabled */
> --
> 2.39.2
