From: Ben Skeggs <bske...@redhat.com>

- we'll want this info post-UPDATE for later patches

Signed-off-by: Ben Skeggs <bske...@redhat.com>
Reviewed-by: Lyude Paul <ly...@redhat.com>
---
 drivers/gpu/drm/nouveau/dispnv50/disp.c | 10 ++++++----
 1 file changed, 6 insertions(+), 4 deletions(-)

diff --git a/drivers/gpu/drm/nouveau/dispnv50/disp.c 
b/drivers/gpu/drm/nouveau/dispnv50/disp.c
index 165bc6a0d563..11790ced2b7d 100644
--- a/drivers/gpu/drm/nouveau/dispnv50/disp.c
+++ b/drivers/gpu/drm/nouveau/dispnv50/disp.c
@@ -2082,7 +2082,7 @@ nv50_disp_atomic_commit_tail(struct drm_atomic_state 
*state)
        nv50_crc_atomic_init_notifier_contexts(state);
 
        /* Update output path(s). */
-       list_for_each_entry_safe(outp, outt, &atom->outp, head) {
+       list_for_each_entry(outp, &atom->outp, head) {
                const struct drm_encoder_helper_funcs *help;
                struct drm_encoder *encoder;
 
@@ -2096,9 +2096,6 @@ nv50_disp_atomic_commit_tail(struct drm_atomic_state 
*state)
                        help->atomic_enable(encoder, state);
                        interlock[NV50_DISP_INTERLOCK_CORE] = 1;
                }
-
-               list_del(&outp->head);
-               kfree(outp);
        }
 
        /* Update head(s). */
@@ -2196,6 +2193,11 @@ nv50_disp_atomic_commit_tail(struct drm_atomic_state 
*state)
        if (atom->lock_core)
                mutex_unlock(&disp->mutex);
 
+       list_for_each_entry_safe(outp, outt, &atom->outp, head) {
+               list_del(&outp->head);
+               kfree(outp);
+       }
+
        /* Wait for HW to signal completion. */
        for_each_new_plane_in_state(state, plane, new_plane_state, i) {
                struct nv50_wndw_atom *asyw = nv50_wndw_atom(new_plane_state);
-- 
2.41.0

Reply via email to