On Wed, 2026-01-14 at 00:11 +0100, Danilo Krummrich wrote: > On Tue Jan 13, 2026 at 11:53 PM CET, Timur Tabi wrote: > > It seems that a lot of the feedback from the last version has not been > addressed: > > > Alexandre Courbot (1): > > gpu: nova-core: implement BinaryWriter for LogBuffer > > https://lore.kernel.org/all/[email protected]/ > > > Timur Tabi (8): > > rust: pci: add PCI device name method > > https://lore.kernel.org/all/[email protected]/ > > > gpu: nova-core: Replace module_pci_driver! with explicit module init > > https://lore.kernel.org/all/[email protected]/
Sorry, I couldn't find these messages in my inbox. I will address them in v5. > > gpu: nova-core: use pin projection in method boot() > > rust: debugfs: implement Directory trait for Dir > > rust: debugfs: wrap Entry in an enum to prep for LookupDir > > rust: debugfs: add LookupDir > > https://lore.kernel.org/all/[email protected]/ > > Especially this one is a concern, I don't want to add this infrastructure as a > workaround until we land the feature Gary works on. > > As mentioned in this reply, I think that debugfs_lookup() rarely is the > correct > solution and more often indicates some kind of (design) issue, like it does in > this case. Well, I'm at a loss how to proceed, then. I had a global variable, which is the approach that Nouveau uses, it was recommended instead that I use debugfs_lookup(). So I implemented that, but that is also rejected. So instead of just telling me that this approach is wrong, please tell what the correct approach should be. Please note that this patchset is already pushing the limits of my R4L skills, so I will need specifics. > Before adding this, I would like to see a valid use-case elsewhere. I don't have one. > If we want this before Gary's work is ready, I prefer some hacky temporary > workaround in nova-core to access the module field instead. Danilo, you are the one who has been pushing for this code. Please note that the logging buffers can only be parsed by Nvidia employees anyway, and we can just use this patchset in house to debug GSP-RM as needed. So if you want to wait until Gary's work is ready (I don't know anything about what he's doing), please let me know now and I will just keep these patches internally.
