On 1/26/26 5:08 AM, Gary Guo wrote:
> On Sat Jan 24, 2026 at 1:42 AM GMT, John Hubbard wrote:
>> On 1/23/26 5:38 PM, John Hubbard wrote:
>>> On 1/21/26 8:35 AM, Gary Guo wrote:
>>>> On Wed Dec 3, 2025 at 5:59 AM GMT, John Hubbard wrote:
...
>>      // SAFETY: fmc_full, which contains the complete FMC ELF file, is never 
>> submitted to
>>      // hardware, so it is safe from hardware-software races. And we are the 
>> unique owner of
>>      // fsp_fw (and therefore of fsp_fw.fmc_full). (A separate buffer, 
>> fsp_fw.fmc_image, is what
>>      // gets submitted to the hardware).
>>      let fmc_full_data = unsafe { fsp_fw.fmc_full.as_slice(0, 
>> fsp_fw.fmc_full.size())? };
> 
> If they're never submitted to hardware, why are they dma objects?
> 

ah, right. That's leftover from my earlier bringup work. Of course,
these can be separate allocations. If I change fmc_full to KVec<u8>,
then the whole unsafe block just disappears.

I've fixed this for v2, thanks for spotting that.

thanks,
-- 
John Hubbard

Reply via email to