On 1/28/2026 5:53 AM, Danilo Krummrich wrote:
On Mon Jan 26, 2026 at 9:23 PM CET, Joel Fernandes wrote:
@@ -267,7 +264,12 @@ fn new_fwsec(dev: &Device<device::Bound>, bios: &Vbios, cmd:
FwsecCommand) -> Re
let ucode = bios.fwsec_image().ucode(&desc)?;
let mut dma_object = DmaObject::from_data(dev, ucode)?;
- let hdr_offset = usize::from_safe_cast(desc.imem_load_size() + desc.interface_offset());
+ // Compute hdr_offset = imem_load_size + interface_offset.
I do get the idea behind those comments, but are we sure that's really a good
idea? How do we ensure to keep them up to date in case we have to change the
code?
If we really want this, I'd at least chose a common syntax, e.g.
// CALC: `imem_load_size + interface_offset`
without the variable name the resulting value is assigned to.
But I'd rather prefer to just drop those comments.
The idea of adding these comments was to improve readability. However, I
can drop them in the v3, that's fine with me.
Do you want me to wait for additional comments on this series, or should
I make the update and repost it? Thanks,
--
Joel Fernandes
