On Sat, 2026-01-17 at 12:24 +0100, Danilo Krummrich wrote:
> > -kernel::module_pci_driver! {
> > -    type: driver::NovaCore,
> > +#[pin_data]
> > +struct NovaCoreModule {
> > +    #[pin]
> > +    _driver: kernel::driver::Registration<pci::Adapter<driver::NovaCore>>,
> 
> Let's import driver, such that this becomes driver::Registration<_>.

We already have "mod driver", so if I try to import kernel::driver, the 
compiler just complains.  I
can import driver::Registration, but that just gets me:

    _driver: Registration<pci::Adapter<driver::NovaCore>>,

I don't see how I can replace this with just driver::Registration<_>.

> > +        })
> > +    }
> > +}
> > +
> > +module! {
> > +    type: NovaCoreModule,
> >       name: "NovaCore",
> >       authors: ["Danilo Krummrich"],
> >       description: "Nova Core GPU driver",
> >       license: "GPL v2",
> > -    firmware: [],
> 
> Should be a separate patch.

I'll just put it back.

Reply via email to