Hi Lars, in 407 I added a small "isMac()" util.
I can change it to isWin() and update the patch (I do not believe, that the return code is 1 on Linux for the patch, I'd assume it is 127 on Linux as well) On Mon, Apr 18, 2011 at 3:51 PM, Lars Corneliussen <m...@lcorneliussen.de> wrote: > That is a regression. I tried to catch "Command line to long" for cmd.exe. > This test should only run on windows. > > Brett, do we support categories by os? > > -- > Message sent from mobile device > > Am 18.04.2011 um 15:47 schrieb Matthias Wessendorf <mat...@apache.org>: > >> Hi, >> >> in my previous email, I reported to JUnit test failures. >> >> One I corrected already ([1]) - The patch contains a bit of documentation. >> (as stated in the bug - I am surprised that on Linux the return-code >> is 1 as well for 'command not found') >> >> The second failure: >> >> testTooLongCommandName_withSpace(npanday.executable.CommandExecutorTest) >> >> generates something like: >> /bin/bash -c echo xxxxxxxxxxxxx................. >> >> Not sure I get why you are expecting a test failure here. >> >> Thanks! >> Matthias >> >> [1] https://issues.apache.org/jira/browse/NPANDAY-407 >> >> -- >> Matthias Wessendorf >> >> blog: http://matthiaswessendorf.wordpress.com/ >> sessions: http://www.slideshare.net/mwessendorf >> twitter: http://twitter.com/mwessendorf > -- Matthias Wessendorf blog: http://matthiaswessendorf.wordpress.com/ sessions: http://www.slideshare.net/mwessendorf twitter: http://twitter.com/mwessendorf
