[ 
https://issues.apache.org/jira/browse/NPANDAY-599?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14055757#comment-14055757
 ] 

Brett Porter commented on NPANDAY-599:
--------------------------------------

In my last commit moving the resolver, I changed to generated component 
metadata, and removed the "per-lookup" on many of those classes, so the cache 
should be a singleton now.

[~lcorneliussen] can you review and let me know if that would address this 
issue, or if it might have any unintended consequences I didn't anticipate?

> Cache resolve-result reactor-wide to avoid pdb/gac/++ beeing resolved 
> multiple times
> ------------------------------------------------------------------------------------
>
>                 Key: NPANDAY-599
>                 URL: https://issues.apache.org/jira/browse/NPANDAY-599
>             Project: NPanday
>          Issue Type: Sub-task
>          Components: Maven Plugins
>            Reporter: Lars Corneliussen
>             Fix For: 1.5.0-incubating
>
>
> Currently it seems like our custom contributors/resolvers execute for every 
> possible path (artifact.getDependencyTrail() changes...).
> We can cache what we resolved reactor-wide in a separate component.
> Cachekey would be artifact.getId(), right?
> Should we let each contributor implement the cache 
> (ArtifactResolvingContributor) - or should it be generically handled in the 
> artifact resolver? 



--
This message was sent by Atlassian JIRA
(v6.2#6252)

Reply via email to