Hi Dominique, Dominique Leuenberger wrote: > On Wed, 2009-12-09 at 21:52 +0100, Jean-Pierre ANDRE wrote: > >>> True... if there is a decision upstream and a patch available there is >>> nothing better that could happen. I will gladly apply the same patch to >>> the openSUSE packages! >>> >> >> I will post a workaround to morrow (undef'ing the const) >> > > I think the problem with undef'ing is that there are more places > affected by this. For example, if I now disable that patch stripping out > AC_C_CONST, then the error I get now is: > > attrib.c: In function 'ntfs_get_attribute_value': > attrib.c:153: error: passing argument 1 of 'ntfs_log_redirect' discards > qualifiers from pointer target type > ../include/ntfs-3g/logging.h:65: note: expected 'char *' but argument is > of type 'const char *' > attrib.c:241: error: passing argument 1 of 'ntfs_log_redirect' discards > qualifiers from pointer target type > > There might certainly more of those occurrences appear over time. > Considering the fact that autoconf devs say that this macro should no > longer be needed, I'm wondering what rationale there might be to still > use it for ntfs-3g. Are there really any non ANSI C89 compilers being > used to build this? >
When I said to-morrow, it was only for secaudit, as I thought you had a patch set from a previous version for the old files. The conflict will happen whenever "config.h" is not the first included file. Most of the time it can be put as the first one, but for secaudit, this is tricky because it is organized for four environments. My proposal is still valid... for secaudit only. And yes, I really doubt ntfs-3g can be compiled with a pre C89 compiler (this means no prototype, and a different syntax for function headers). Regards Jean-Pierre ------------------------------------------------------------------------------ Return on Information: Google Enterprise Search pays you back Get the facts. http://p.sf.net/sfu/google-dev2dev _______________________________________________ ntfs-3g-devel mailing list [email protected] https://lists.sourceforge.net/lists/listinfo/ntfs-3g-devel
