Hi Fabian, Fabian Keil wrote: > Jean-Pierre André<[email protected]> wrote: > > >> Szabolcs Szakacsits wrote: >> > >> I also reject 0006, which would probably make the >> variable cnt uninitialized when first used. >> > The first use of cnt seems to be storing the return code of > mbrtowc(), so I don't see how it could be used uninitialized, > but of course the patch is unimportant anyway and I wouldn't > have submitted it on its own.
That is an interesting case. I wrote "probably" because the checking required some effort, and I would have to put the same effort some time later, when searching for a possible problem in the same area. Automatic error detection should not lead to make code less maintainable. Maybe you can parameter your tool to not warn about double setting of a variable, which is removed by the optimizer anyway. This leaves five erroneous (or at least suspicious) cases which your tool detected, leading to an improved ntfs-3g. Thank you for that. Regards Jean-Pierre ------------------------------------------------------------------------------ Throughout its 18-year history, RSA Conference consistently attracts the world's best and brightest in the field, creating opportunities for Conference attendees to learn about information security's most important issues through interactions with peers, luminaries and emerging and established companies. http://p.sf.net/sfu/rsaconf-dev2dev _______________________________________________ ntfs-3g-devel mailing list [email protected] https://lists.sourceforge.net/lists/listinfo/ntfs-3g-devel
