Jean-Pierre André <[email protected]> wrote: > At first glance, most of these attached proposals have > already been fixes in ntfs-3g-2011.4.12AR.4 following > warnings by gcc 4.6 (variables set but not used).
Hmm, I checked against:
git://ntfs-3g.git.sourceforge.net/gitroot/ntfs-3g/ntfs-3g
but now I realise that it may not be up to date.
> I see you have detected at least one real bug (missing
> braces in runlist.c), and I will check them all in detail.
Great, thanks.
> Fabian Keil wrote:
> > Hi,
> >
> > the attached patches 1-4 fix what look like potential problems
> > to me, 5-10 fix clang warnings but the issues should be harmless.
> >
> > I'm not sure about this code from libntfs-3g/attrib.c:
> >
> > 5328 if (bytes_read != na->initialized_size) {
> > 5329 if (bytes_read< 0)
> > 5330 err = errno;
> > 5331 ntfs_log_trace("Eeek! Failed to read attribute
> > data. Leaving "
> > 5332 "inconstant metadata. Run chkdsk.
> > "
> > 5333 "Aborting...\n");
> > 5334 errno = err;
> > 5335 return -1;
> > 5336 }
> >
> > Is it correct, should lines 5329, 5330 and 5334 be removed,
> > or do lines 5330 to 5334 belong to the if in 5329?
> >
>
> No, this looks like being intentional, the trace may trigger
> a new error, and the errno to be reported to the application
> if the one defined by the driver, which is either the one
> returned by the read call, or the default EIO as set before.
Thanks for the explanation.
Fabian
signature.asc
Description: PGP signature
------------------------------------------------------------------------------ BlackBerry® DevCon Americas, Oct. 18-20, San Francisco, CA The must-attend event for mobile developers. Connect with experts. Get tools for creating Super Apps. See the latest technologies. Sessions, hands-on labs, demos & much more. Register early & save! http://p.sf.net/sfu/rim-blackberry-1
_______________________________________________ ntfs-3g-devel mailing list [email protected] https://lists.sourceforge.net/lists/listinfo/ntfs-3g-devel
