Hi, Bogdan wrote: > > Done (including the "+1" from your last mail). This also isn't my > code (I'm only using this function), but the changes were simple. >
Oh, I have lost track of where each part of the code came from... Sorry for the confusion. >> There is a single tail, this should not be in a loop. >> > Can't do that. The "size" and "offset" variables can be changed on > each iteration, so they have to be re-set to the correct values. > Actually no change is needed. The tail is only wiped once during the last iteration in the loop. >> In the main wipe_tail function, you only process the >> unnamed data attribute : >> >> na = ntfs_attr_open(ni, AT_DATA, AT_UNNAMED, 0); >> >> But there can also be named data attributes, you should >> do a "while (!ntfs_attr_lookup(AT_DATA, ... ))" >> > The ntfs_attr_lookup() function requires a ntfs_attr_search_ctx > variable, which can be obtained by calling > ntfs_attr_get_search_ctx(NULL, mft). But the "mft" comes from reading > the attribute, so we have to have it open already anyway, unless I'm > missing other methods to do this. > Yes, some more code is needed. There are other instances of this which may serve as a starting base. (I will do it when I have some spare time). > I corrected the coding style (80-char line length limit and > parenthesis, the same as in other files), hope it's better now. You > Thanks. > should consider adding a make target to automatically correct the > files (with the "indent" utility, just like the SWIG project, which > I've recently encountered). > > New version of the full patch attached. I've removed the changes from > utils.c and layout.h. Apply over clean ntfs-3g_ntfsprogs-2012.1.15. Thank you for your contribution. I will merge it into a future version, when I have checked it again. Regards Jean-Pierre ------------------------------------------------------------------------------ Live Security Virtual Conference Exclusive live event will cover all the ways today's security and threat landscape has changed and how IT managers can respond. Discussions will include endpoint security, mobile security and the latest in malware threats. http://www.accelacomm.com/jaw/sfrnl04242012/114/50122263/ _______________________________________________ ntfs-3g-devel mailing list [email protected] https://lists.sourceforge.net/lists/listinfo/ntfs-3g-devel
