Hi,

Ulf Zibis wrote:
> Hi Jean-Pierre,
>
> to ease my work, I did some code cleanup, see attachment.
>
> Maybe you like it.
>
> -Ulf

This is a strange cleanup, which causes unacceptable regressions.

Sorry, I cannot accept them, they do not even pass the self-tests
internal to secaudit :

[linux@dimension acls]$ ./secaudit -t | grep Error
** Error in sample 1, perms 0770 expected 0777
** Error in sample 2, perms 0770 expected 0777
** Error in sample 4, perms 0730 expected 0731
** Error in sample 9, perms 0770 expected 0777
** Error in sample 10, perms 0770 expected 0777

I will not accept any change which breaks an existing test,
and is likely to break the interpretation of ACLs in a lot
of existing users files.

Moreover you have merged cosmetic changes in them. Please keep
cosmetic changes apart with no code change at all.

Finally, how did you get into the condition you are trying to fix ?

Jean-Pierre


------------------------------------------------------------------------------
Site24x7 APM Insight: Get Deep Visibility into Application Performance
APM + Mobile APM + RUM: Monitor 3 App instances at just $35/Month
Monitor end-to-end web transactions and take corrective actions now
Troubleshoot faster and improve end-user experience. Signup Now!
http://pubads.g.doubleclick.net/gampad/clk?id=272487151&iu=/4140
_______________________________________________
ntfs-3g-devel mailing list
[email protected]
https://lists.sourceforge.net/lists/listinfo/ntfs-3g-devel

Reply via email to