Hi Ludovico On Mar 5, 2012, at 3:13 AM, Ludovico Cavedon wrote:
> On Sun, Mar 4, 2012 at 12:37 AM, Luca Deri <[email protected]> wrote: >> I have looked at your patches and honestly I am not sure they address the >> issues you reported >> >> - u_char *tcp_data = (u_char *)(tcp + tp.th_off * 4); >> + u_char *tcp_data = ((u_char *) tcp) + tp.th_off * 4; >> The above does not seem to change much the meaning; can you please explain >> why you believe it's better this way? > > "tcp" is not a pointer to char, but to a struct tcphdr. Therfore when > you increment it by N, you are not incrementing it by N bytes, but > N*sizeof(struct tcphdr) bytes. In C words: > u_char *tcp_data = (u_char *)(tcp + tp.th_off * 4); > is equivalent to > u_char *tcp_data = ((u_char *) tcp) + tp.th_off * 4 * sizeof(struct tcphdr); fixed. please check if you like the patch > >> - theSession->l7.major_proto = IPOQUE_MAX_SUPPORTED_PROTOCOLS + rc; >> + theSession->l7.major_proto = rc; >> As for the second patch, as soon as I have some time, I believe I should >> completely remove from ntop the support of extra protocols based on ports, >> and move it to nDPI. > > I see. However as it is in the rc0 tarball, it is causing an > out-of-bound memory access (and possibly crash) because it later does > myGlobals.device[actualDeviceId].l7.protoTraffic[theSession->l7.major_proto] > += h->len; > where myGlobals.device[actualDeviceId].l7.protoTraffic is an array of > size IPOQUE_MAX_SUPPORTED_PROTOCOLS. > > Also, if I run rc0 on my laptop I see all HTTPS traffic under the > Mail_POP column. > Or is this supposed to be fixed in SVN? Looks like there's something out of fix. Please get the new release (an email will follow) > I prefer to upload a version that has been tagged by you (i.e. like an > rc0), rather than an arbitrary SVN revision. However if you prefer me > to upload a specific SVN revision, I will do that. Use the RC > >> The license is kind of hard for me as I am not an expert. Highcharts are >> distributed with http://creativecommons.org/licenses/by-nc/3.0/ that I >> believe it's good. If you don't like it for Debian packages, then I need to >> find an alternative as ntop without charts is not a good idea. What other >> alternatives shall I look at, that are compatible with Debian packages? > > The problem with the CC-BY-NC is the NC (Non-Commercial) part, which > states that you cannot use Highcharts (and therefore ntop either) for > commercial purposes, and this is considered non-free for Debian. > > The plain Creative Commons 3.0 license is good, as well the classic > GPL/LGPL/BSD/MIT/Expat/Apache/etc licenses. > This is a big pain the neck as due to these limitations, I need to change JS library. Yes suggestions are welcome but we need to recode many parts of ntop and honestly I liked these charts. Cheers Luca > Thank your for your quick response! > Ludovico > _______________________________________________ > Ntop-dev mailing list > [email protected] > http://listgateway.unipi.it/mailman/listinfo/ntop-dev --- "Debugging is twice as hard as writing the code in the first place. Therefore, if you write the code as cleverly as possible, you are, by definition, not smart enough to debug it. - Brian W. Kernighan _______________________________________________ Ntop-dev mailing list [email protected] http://listgateway.unipi.it/mailman/listinfo/ntop-dev
