On 01/10/2012 19:36, Luca Deri wrote:

I have committed your patches: many thanks. Can we also merge your work on the 
opendpi  module? Of course if I have changed something that broken your work we 
can fix it. If you want write commit on the SVN repository please let me know

and also I need a prototype for "ndpi_int_add_connection()" (in fact could the 
whole removal of the prototypes in ndpi_protocol_history.h be reverted and they be all 
left in for use by external modules?)

Hi, what do you think about reverting the complete set of prototypes in ndpi_protocol_history? I just added in that one quick stub because I needed it, but previously there was a suite of functions - could someone else want access to them?
https://github.com/thomasbhatia/OpenDPI/blob/master/src/lib/ipq_protocol_history.h



Note, my updates to the netfilter module are here:
    https://github.com/ewildgoose/ndpi-netfilter

At present it "compiles", but I can't test it because I need my machine with netlink conntrack support, so currently the module fails to insert because I can't call nf_conntrack_register_notifier on my kernel (already grabbed by the conntrack netlink module).

I'm pondering how I can possibly work around this... Thoughts on how to decouple this from conntrack appreciated? (Not least because there is a risk of leaks, conntrack doesn't always track every flow you think it should, as I already discovered..)


Anyone a netfilter expert..?

Ed W
_______________________________________________
Ntop-dev mailing list
[email protected]
http://listgateway.unipi.it/mailman/listinfo/ntop-dev

Reply via email to