Two problems just on the face of it...
1) The O option is out of alphabetical sequence in theOpts
2) The case 'O' statement is out of alphabetical sequence in the while
statement
Finally, it won't apply against any reasonably current version of ntop, due
to reorganization (usage() is now in main.c, for example, not
webInterface.c), the long options and myGlobals change, and that surfaces:
3) There should be a corresponding long options value
4) The structure of options handling in the while loop has changed to this:
case 'a': /* ntop access log path */
stringSanityCheck(optarg);
myGlobals.accessLogPath = strdup(optarg);
break;
(All of these are standards we're trying to put in place going forward)
Minor "English" issue in the documentation, "the string for this to work
fine" might sound better as "the string for this to work properly".
That's all based on reading the diff. There's a lot of Debian stuff I don't
understand - and I haven't actually tried it, but it seems IMHO a reasonable
patch.
-----Burton
-----Original Message-----
From: [EMAIL PROTECTED] [mailto:[EMAIL PROTECTED]]On Behalf
Of Dennis Schoen
Sent: Friday, March 22, 2002 2:07 AM
To: [EMAIL PROTECTED]
Subject: [Ntop-dev] [[EMAIL PROTECTED]: New option for ntop.]
Can someone review this patch please. If nobody objects I'll apply
it to CVS.
Ciao
Dennis
_______________________________________________
Ntop-dev mailing list
[EMAIL PROTECTED]
http://listmanager.unipi.it/mailman/listinfo/ntop-dev
