Good find ...
For form's sake, might want to use
#if defined(MULTITHREADED) && defined(ASYNC_ADDRESS_RESOLUTION)
in the plugin, so it's the same test as in address.c, report.c,
reportUtils.c and webInterface.c
actually, there are a couple of OTHER places which need their tests
adjusted... grepping the code gives:
address.c OK
initialize.c needs correx
ntop.c OK
plugins/icmpPlugin.c your fix
plugins/nfsPlugin.c needs correx
report.c OK
reportUtils.c OK
util.c needs correx
webInterface.c OK
Would you like to try fixing the other three and sending a combined patch?
FWIW, patches (once you're ready to have them applied) should be sent to the
special address, [EMAIL PROTECTED] -- Luca usually won't look at attachments
sent to any other address.
-----Burton
-----Original Message-----
From: [EMAIL PROTECTED] [mailto:[EMAIL PROTECTED]]On Behalf
Of Tim Gardner
Sent: Thursday, January 02, 2003 1:23 PM
To: NTOP Developers List
Subject: [Ntop-dev] icmpPlugin.c patch to fix addressResolutionMutex
access bug.
The ICMP plugin was incorrectly using addressResolutionMutex if it was not
initialized. See attached.
--
Tim Gardner - [EMAIL PROTECTED] 406-443-5357
TriplePoint, Inc. - http://www.tpi.com
PGP: http://www.tpi.com/PGP/Tim.txt
_______________________________________________
Ntop-dev mailing list
[EMAIL PROTECTED]
http://listgateway.unipi.it/mailman/listinfo/ntop-dev
