I well know that it's easy to make a change that fixes a problem in ONE environment
and not realize it breaks nine others.
Luca, I didn't put that patch in lightly. I developed and tested it to fix a lot of
the problems with the configure.in file and to better support -- based on feedback
from actual users -- the wide range of environments we support ntop under.
I did my development under RH8. I then rebuilt Owl - my test box - using fresh
downloaded copies of ELEVEN OS/Distros:
Redhat 7.3, 8.0 and 9
Gentoo 1.4
Mandrake 9.1
Slackware 9.0.0
Debian 3.0 (Woody)
FreeBSD 4.8 and 5.1
NetBSD 1.6.1
Solaris 8 i86
In each case, I did a minmal install and added the minimal tools and libraries to
compile and run ntop.
I tweaked the patch so that it configured and compiled ntop correctly in EVERY ONE of
those ELEVEN environments. The only ones I don't have access to are the 12th and 13th
environments we support, a Mac (don't own one) and Win32 (don't own VC++ 6).
The patch worked in all eleven environments, so I committed it.
I'm sorry it doesn't work in the Mac.
The fact remains that your Mac 'fix' while successful and required for the Mac, breaks
the other eleven. It does so in a subtle way - it's only apparent if you download a
fresh copy of the cvs and try to ./configure - if you just do a cvs co && ./configure
it works fine, because you've already compiled myrrd and so the -L$MYRRD -lmyrrd can
be resolved. But it does break on a fresh directory.
Adding the seven lines to case the Mac vs. non-Mac version solves it - both worlds
have their necessary configuration data.
Same with the twenty or thirty lines to set various flags for different OS/Distros -
yes, it's not pretty and it *is* subject to breakage as new releases are issued. But
it would be trivial to add a 'unknown distro/release' warning (just like the ones we
have for unknown OS) and require manual settings + the --enable-iknowbetter flag to
continue. I'll prepare and test that...
Updating the ntop version of libtool also fixes some problems. I'm still waiting for
feedback from users, but what do you think about updating it?
-----Burton
---------- Original Message ----------------------------------
From: Luca Deri <[EMAIL PROTECTED]>
Reply-To: [EMAIL PROTECTED]
Date: Fri, 8 Aug 2003 09:41:24 +0200
>Loic and Burton,
>I understand that's easy to drop a mail to ~1'000 people accusing me.
>On the other hand you must have clear in mind that you patch doesn't
>work on OSX. Hence although I could say (reusing your words) that
>you've screwed the code again, I won't say that because:
>- I know how difficult it is to write portable code.
>- Our work is voluntary and we do our best to serve the community
>
>For the future I suggest you to think twice before posting.
>
>Luca
>
>On Gioved�, agosto 7, 2003, at 05:21 PM, B. Lo�c wrote:
>
>> "Burton M. Strauss III" a �crit :
>>
>>> Well, I guess Luca screwed up the configure.in file again when he
>>> hacked on
>>> it for the Mac.
>>
>> I guess you guessed right... ;-)
>>
>>> It's probably this piece:
>>>
>>> @@ -1332,7 +1354,7 @@
>>> dnl> Presets for the make flags go here...
>>> CFLAGS="${CFLAGS}"
>>> CPPFLAGS="${CPPFLAGS}"
>>> -LDFLAGS="${LDFLAGS}"
>>> +LDFLAGS="${LDFLAGS} -L$MYRRD -lmyrrd"
>>
>>> try reverting the change. rebuilding configure via autoconf and let
>>> us know.
>>
>> This did work.
>> configure runs fine now.
>>
>> Thank you
>>
>> Lo�c
>>
>>
>>
>> _______________________________________________
>> Ntop-dev mailing list
>> [EMAIL PROTECTED]
>> http://listgateway.unipi.it/mailman/listinfo/ntop-dev
>>
>
>-------
>Luca Deri <[EMAIL PROTECTED]>
>
>_______________________________________________
>Ntop-dev mailing list
>[EMAIL PROTECTED]
>http://listgateway.unipi.it/mailman/listinfo/ntop-dev
>
____________________________________________________________
Free 20MB Web Site Hosting and Personalized E-mail Service!
Get It Now At Doteasy.com http://www.doteasy.com/et/
_______________________________________________
Ntop-dev mailing list
[EMAIL PROTECTED]
http://listgateway.unipi.it/mailman/listinfo/ntop-dev
