Actually, while at it: I could not discover the sense of the
switch-statement in printTableEntry. When I removed the cases for 0 and
100 (%) and only left the "default" entry, the function would still
produce the correct table entries. Also for cases when the value was 0
or 100.
It all depends on the right math, and since that's in place, why keep
the 0 and 100 cases? It doesn't seem to be eating that much CPU and
keeping multiple instances of the same HTML in the code has proven to be
a pain in the ass (at least to me, today).
Regards,
Robbert
-------- Original Message --------
Subject: [Ntop-dev] New ntop commit (author robbert)
Date: Sun, 3 Apr 2005 10:02:00 -0700
From: [EMAIL PROTECTED]
Reply-To: [email protected]
Organization: Centro di Servizi per la rete di Ateneo - Pisa - Italy
To: [email protected]
Update of /export/home/ntop/ntop
In directory unknown:/tmp/cvs-serv907
Modified Files:
reportUtils.c
Log Message:
Fix voor printTableEntry so that the bars don't start floating when at
100%. Noticable only in Firefox, not in IE.
--- reportUtils.c.orig 2005-04-03 18:16:10.839448632 +0200
+++ reportUtils.c 2005-04-03 18:56:32.611283352 +0200
@@ -4268,7 +4269,7 @@
case 100:
safe_snprintf(__FILE__, __LINE__, buf, bufLen, "<TR "TR_ON" %s><TH
"TH_BG" ALIGN=LEFT WIDTH=150 "DARK_BG">%s</TH>"
"<TD "TD_BG" ALIGN=RIGHT WIDTH=50>%s %s</TD><TD
"TD_BG" ALIGN=RIGHT WIDTH=50>100%%</TD>"
- "<TD ALIGN=CENTER WIDTH=200><IMG ALT=\"100%%\"
ALIGN=MIDDLE SRC=\"/gauge.jpg\" WIDTH=200 HEIGHT=12>"
+ "<TD "TD_BG" WIDTH=200><IMG ALT=\"100%%\" ALIGN=MIDDLE
SRC=\"/gauge.jpg\" WIDTH=200 HEIGHT=12>"
"</TD></TR>\n",
getRowColor(), label, formatKBytes(total, formatBuf,
sizeof(formatBuf)), flowBuf);
break;
_______________________________________________
Ntop-dev mailing list
[email protected]
http://listgateway.unipi.it/mailman/listinfo/ntop-dev
_______________________________________________
Ntop-dev mailing list
[email protected]
http://listgateway.unipi.it/mailman/listinfo/ntop-dev
