I've found two problems in recent snapshots, that prevent basic ntop from
compiling... both minor...

1. dumpNtopHashes and dumpNtopTrafficInfo

This had been double defined, globals-core.h and globals-report.h and was
updated (added a parameter) in only one place.

Bypass: in globals-core.h, delete these lines (69-71)

     /* emitter.c */
     extern void dumpNtopHashes(char* options, int actualDeviceId);
     extern void dumpNtopTrafficInfo(char* options);

Change went in: 26Feb2002
Bad snapshots:  ntop-02-02-27.tgz
Fixed snapshot: ntop-02-02-28.tgz

     [bstrauss@tigger source]$ cd ntop-2002-02-26
     [bstrauss@tigger ntop-2002-02-26]$ qg dumpNtopHashes *.h
          globals-core.h:    70   extern void dumpNtopHashes(char* options,
int actualDeviceId);
        globals-report.h:   100   extern void dumpNtopHashes(char*, int
actualDeviceId);
     [bstrauss@tigger ntop-2002-02-26]$ cd ../ntop-2002-02-27
     [bstrauss@tigger ntop-2002-02-27]$ qg dumpNtopHashes *.h
          globals-core.h:    70   extern void dumpNtopHashes(char* options,
int actualDeviceId);
        globals-report.h:   100   extern void dumpNtopHashes(FILE*, char*,
int actualDeviceId);
     [bstrauss@tigger ntop-2002-02-27]$ cd ../ntop-2002-02-28
     [bstrauss@tigger ntop-2002-02-28]$ qg dumpNtopHashes *.h
        globals-report.h:   100   extern void dumpNtopHashes(FILE*, char*,
int actualDeviceId);


2. emableDBsupport not defined

Moved enableDBsupport to myGlobals, but missed one spot - main.c line 499

      handlemySQLSupport(optarg, &enableDBsupport);
s/b
      handlemySQLSupport(optarg, &myGlobals.enableDBsupport);

Change went in: 25Feb2002
Bad snapshots:  ntop-02-02-28.tgz, ntop-02-02-27.tgz, ntop-02-02-26.tgz
OK snapshots:   <= ntop-02-02-25.tgz

     ntop-2002-02-25/main.c:405:      handleDbSupport(optarg,
&enableDBsupport);
     ntop-2002-02-25/main.c:518:      handlemySQLSupport(optarg,
&enableDBsupport);

     ntop-2002-02-26/main.c:386:      handleDbSupport(optarg,
&myGlobals.enableDBsupport);
     ntop-2002-02-26/main.c:499:      handlemySQLSupport(optarg,
&enableDBsupport);

     ntop-2002-02-27/main.c:386:      handleDbSupport(optarg,
&myGlobals.enableDBsupport);
     ntop-2002-02-27/main.c:499:      handlemySQLSupport(optarg,
&enableDBsupport);

     ntop-2002-02-28/main.c:386:      handleDbSupport(optarg,
&myGlobals.enableDBsupport);
     ntop-2002-02-28/main.c:499:      handlemySQLSupport(optarg,
&enableDBsupport);

This has not yet been corrected...

I'm not saying don't use 'em, just be prepared to make the source fix.

-----Burton

_______________________________________________
Ntop-dev mailing list
[EMAIL PROTECTED]
http://listmanager.unipi.it/mailman/listinfo/ntop-dev

Reply via email to