On 8/29/06, Tim Hochberg <[EMAIL PROTECTED]> wrote:
There are certainly many methods where inplace operations make no sense. But for such things as conjugate and clip I think it should be preferred. Think of them as analogs of the "+=" operators that allow memory efficient inplace operations. At the moment there are too few such operators, IMHO, and that makes it hard to write memory efficient code when you want to do so. If you need a copy, the functional form should be the preferred way to go and can easily be implement by constructions like a.copy().sort().
Chuck
Charles R Harris wrote:
> Hi,
>
> On 8/29/06, *Tim Hochberg* <[EMAIL PROTECTED]
> <mailto:[EMAIL PROTECTED] >> wrote:
>
>
> -0.5 from me if what we're talking about here is having mutating
> methods
> return self rather than None. Chaining stuff is pretty, but having
> methods that mutate self and return self looks like a source of
> elusive
> bugs to me.
>
> -tim
>
>
> But how is that any worse than the current mutating operators? I think
> the operating principal is that methods generally work in place,
> functions make copies. The exceptions to this rule need to be noted.
Is that really the case? I was more under the impression that there
wasn't much rhyme nor reason to this. Let's do a quick dir(somearray)
and see what we get (I'll strip out the __XXX__ names):
'all', 'any', 'argmax', 'argmin', 'argsort', 'astype', 'base',
'byteswap', 'choose', 'clip', 'compress', 'conj', 'conjugate', 'copy',
'ctypes', 'cumprod', 'cumsum', 'data', 'diagonal', 'dtype', 'dump',
'dumps', 'fill', 'flags', 'flat', 'flatten', 'getfield', 'imag', 'item',
'itemsize', 'max', 'mean', 'min', 'nbytes', 'ndim', 'newbyteorder',
'nonzero', 'prod', 'ptp', 'put', 'putmask', 'ravel', 'real', 'repeat',
'reshape', 'resize', 'round', 'searchsorted', 'setfield', 'setflags',
'shape', 'size', 'sort', 'squeeze', 'std', 'strides', 'sum', 'swapaxes',
'take', 'tofile', 'tolist', 'tostring', 'trace', 'transpose', 'var', 'view'
There are certainly many methods where inplace operations make no sense. But for such things as conjugate and clip I think it should be preferred. Think of them as analogs of the "+=" operators that allow memory efficient inplace operations. At the moment there are too few such operators, IMHO, and that makes it hard to write memory efficient code when you want to do so. If you need a copy, the functional form should be the preferred way to go and can easily be implement by constructions like a.copy().sort().
Hmmm. Without taking too much time to go through these one at a time,
I'm pretty certain that they do not in general mutate things in place.
Probably at least half return, or can return new arrays, sometimes with
references to the original data, but new shapes, sometimes with
completely new data. In fact, other than sort, I'm not sure which of
these does mutate in place.
-tim
Chuck
------------------------------------------------------------------------- Using Tomcat but need to do more? Need to support web services, security? Get stuff done quickly with pre-integrated technology to make your job easier Download IBM WebSphere Application Server v.1.0.1 based on Apache Geronimo http://sel.as-us.falkag.net/sel?cmd=lnk&kid=120709&bid=263057&dat=121642
_______________________________________________ Numpy-discussion mailing list Numpy-discussion@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/numpy-discussion
