On Thu, Jun 13, 2019 at 12:46 PM Stephan Hoyer <[email protected]> wrote: <snip>
> > >> But how about `np.sum` itself? Right now, it is overridden by >> __array_function__ but classes without __array_function__ support can also >> override it through the method lookup and through __array_ufunc__. >> >> Would/should there be a point where we just have `sum = np.add.reduce` >> and drop other overrides? If so, how do we get there? >> >> One option might be start reversing the order in `_wrapreduction` - try >> `__array_ufunc__` if it is defined and only if that fails try the `.sum` >> method. >> > > Yes, I think we would need to do this sort of thing. It's a bit of > trouble, but probably doable with some decorator magic. It would indeed be > nice for sum() to eventually just be np.add.reduce, though to be honest I'm > not entirely sure it's worth the trouble of a long deprecation cycle -- > people have been relying on the fall-back calling of methods for a long > time. > > I guess the one immediate question is whether `np.sum` and the like should be overridden by `__array_function__` at all, given that what should be the future recommended override already works. (And, yes, arguably too late to change it now!) -- Marten > > >> All the best, >> >> Marten >> _______________________________________________ >> NumPy-Discussion mailing list >> [email protected] >> https://mail.python.org/mailman/listinfo/numpy-discussion >> > _______________________________________________ > NumPy-Discussion mailing list > [email protected] > https://mail.python.org/mailman/listinfo/numpy-discussion >
_______________________________________________ NumPy-Discussion mailing list [email protected] https://mail.python.org/mailman/listinfo/numpy-discussion
