On Mon, May 4, 2020 at 8:40 AM Matti Picus <matti.pi...@gmail.com> wrote:
> > On 3/5/20 1:39 pm, Tina Oberoi wrote: > > > > These are the issues that have pull requests merged but still open, > > Please let me know if I am wrong else we can close these issues: > > - Issue #9476 <https://github.com/numpy/numpy/issues/9476> > > - Issue #2802 <https://github.com/numpy/numpy/issues/2802> > > - Issue #11875 <https://github.com/numpy/numpy/issues/11875> > > - Issue #13114 <https://github.com/numpy/numpy/issues/13114> > > - Issue #13758 <https://github.com/numpy/numpy/issues/13758> > > > > Thanks and Regards > > Tina > Thanks for this list Tina! > Tina it would be helpful to directly comment on the issues in question. > If you are unsure the issues are actually resolved, you can add a > comment "Can we close this, probably resolved by ...". If you are sure > they are resolved, go ahead and close them with a message "Resolved by > ...". I agree with that advice, if it's clear-cut you can do this. Most cases were pretty complicated though to assess. If it appears they are too complicated for the "good first issue" > label, you can just remove the label. > A request to maintainers as well: please keep "good first issue" for actually easy things. 3 of these were easy (one of which turned into a hard one during the conversation), but 2 were definitely not. Cheers, Ralf
_______________________________________________ NumPy-Discussion mailing list NumPy-Discussion@python.org https://mail.python.org/mailman/listinfo/numpy-discussion
