On Sun, Jan 16, 2022 at 9:16 AM Sandro Tosi <sandro.t...@gmail.com> wrote:
> Hello, > i'm preparing 1.22.1 for inclusion in Debian, and noticed how the new > numpy has a git submodule to include numpy/SVML in its source tree. > > We are basing the debian package on the github tarball, and that does > not include any submodule, so i'm wondering how important it is to > have the SVML files around when building the packages. > Not using SVML means you're throwing away performance for your users, and using a non untested config on 64-bit Linux. The latter isn't going to be a problem in practice, since SVML was recently introduced. But I'd prefer for Debian to include it. You are using the wrong tarball I believe. I just checked numpy-1.22.1.tar.gz <https://github.com/numpy/numpy/releases/download/v1.22.1/numpy-1.22.1.tar.gz> from our GitHub Releases page, and it does include SVML (at numpy/core/src/umath/svml). If you instead grabbed the autogenerated-by-github "Source code" tarball, that is the wrong one. We'd delete it if we could, but unfortunately that is not possible. > Given it's not immediately possible to include an external set of > files, i'm just trying to balance the effort to inject them and their > usefulness. > > At the same time, i'm wondering if > https://github.com/numpy/numpy/pull/20695 (the PR that introduced > NPY_DISABLE_SVML, also probably > https://github.com/numpy/numpy/pull/20741 for the doc) should be > backported to the 1.22.x branch, so that we can start using it in the > release that introduced that feature. > I followed up on this on the PR. Thanks for pointing out this issue. Cheers, Ralf > > Thanks, > -- > Sandro "morph" Tosi > My website: http://sandrotosi.me/ > Me at Debian: http://wiki.debian.org/SandroTosi > Twitter: https://twitter.com/sandrotosi > _______________________________________________ > NumPy-Discussion mailing list -- numpy-discussion@python.org > To unsubscribe send an email to numpy-discussion-le...@python.org > https://mail.python.org/mailman3/lists/numpy-discussion.python.org/ > Member address: ralf.gomm...@gmail.com >
_______________________________________________ NumPy-Discussion mailing list -- numpy-discussion@python.org To unsubscribe send an email to numpy-discussion-le...@python.org https://mail.python.org/mailman3/lists/numpy-discussion.python.org/ Member address: arch...@mail-archive.com
