Hi all,
I would like to briefly talk about https://github.com/numpy/numpy/pull/30806
which adds C99 Annex G recoveries for complex multiplication and division that
would otherwise result in nan + nanj. CPython has already implemented this and
I attempted bringing this into numpy.
However, after all the investigation that you can see in the PR thread (and a
short discussion with Nathan Goldbaum), we're leaning towards not doing this.
If you look a the latest benchmarks at the bottom of the PR thread, this adds a
small but noticeable overhead even in the cases where there are no recoveries
to be done. Another thing is that no other array libraries like jax or cupy do
this so this would lead to different results among them.
I'm bringing this up in the mailing list to see if any other people have
thoughts and agree or disagree with NOT doing this. I'm looking for arguments
on why we should do this too if you have any. Keep in mind that this closes at
least 4 issues listed in the PR description that should probably be closed as
"won't do" if the decision is to not have this feature in.
Please share any thoughts you might have.
Kind regards,
Iason.
_______________________________________________
NumPy-Discussion mailing list -- [email protected]
To unsubscribe send an email to [email protected]
https://mail.python.org/mailman3//lists/numpy-discussion.python.org
Member address: [email protected]
