Michael: Thanks so much, this is genuinely awesome! Don't forget to email Joe Harrington for your T-shirt - you more than deserve it! ;-)
A few specific comments below On Tue, Sep 29, 2009 at 10:55 AM, Michael Droettboom <[email protected]>wrote: > I now have a rather large patch ready which addresses the following > issues with chararrays. Would it be possible to get SVN commit > priviledges, or would you prefer a patch file? > I hope you're granted privileges (but I can't do that - don't even have 'em myself); I'm pretty sure everyone on scipy-dev monitors this list as well, but if you have to wait more than a few days for an affirmative reply one way or the other, you should try posting there. > 2) Improve documentation > > Every method now has a docstring, and a new page of routines has been > added to the Sphinx tree. > Awesome, thanks! > 4c) Design and create an interface to those methods that will be the > "right way" going forward > > All vectorized string operations are now available as regular functions > in the numpy.char namespace. Usage of the chararray view class is only > recommended for numarray backward compatibility. > Again, thanks for this. But I wonder aloud (asking long-time developers): do we have any systematic ways to steer people in such directions? (This should probably be a new thread...) > A few side notes: > > http://projects.scipy.org/numpy/ticket/1200 (chararray.rstrip > inconsistency) > > This bug I believe should be marked as "won't fix". The inconsistent > handling of trailing whitespace inconsistency is an unfortunate > "feature" of the chararray class, and I am wary that fixing it may break > backward compatibility. However, the new free functions in numpy.char > do not have this inconsistency, so they should be recommended for new code. > OK, sounds "acceptable." And three more times: thank you, thank you, thank you!!! DG > Cheers, > Mike > > David Goldsmith wrote: > > Great, thanks! > > > > DG > > > > On Fri, Sep 25, 2009 at 6:07 AM, Michael Droettboom <[email protected] > > <mailto:[email protected]>> wrote: > > > > David Goldsmith wrote: > > > On Tue, Sep 22, 2009 at 4:02 PM, Ralf Gommers > > > <[email protected] > > <mailto:[email protected]> > > <mailto:[email protected] > > <mailto:[email protected]>>> wrote: > > > > > > > > > On Tue, Sep 22, 2009 at 1:58 PM, Michael Droettboom > > > <[email protected] <mailto:[email protected]> > > <mailto:[email protected] <mailto:[email protected]>>> wrote: > > > > > > Trac has these bugs. Any others? > > > > > > http://projects.scipy.org/numpy/ticket/1199 > > > http://projects.scipy.org/numpy/ticket/1200 > > > http://projects.scipy.org/numpy/ticket/856 > > > http://projects.scipy.org/numpy/ticket/855 > > > http://projects.scipy.org/numpy/ticket/1231 > > > > > > > > > This one: > > > > > > http://article.gmane.org/gmane.comp.python.numeric.general/23638/match=chararray > > > > > > Cheers, > > > Ralf > > > > > > > > > That last one never got "promoted" to a ticket? > > It's a symptom of this bug, that I created and produced a patch for > > yesterday: > > > > http://projects.scipy.org/numpy/ticket/1235 > > > > Mike > > > > > > -- > > Michael Droettboom > > Science Software Branch > > Operations and Engineering Division > > Space Telescope Science Institute > > Operated by AURA for NASA > > > > _______________________________________________ > > NumPy-Discussion mailing list > > [email protected] <mailto:[email protected]> > > http://mail.scipy.org/mailman/listinfo/numpy-discussion > > > > > > ------------------------------------------------------------------------ > > > > _______________________________________________ > > NumPy-Discussion mailing list > > [email protected] > > http://mail.scipy.org/mailman/listinfo/numpy-discussion > > > > -- > Michael Droettboom > Science Software Branch > Operations and Engineering Division > Space Telescope Science Institute > Operated by AURA for NASA > > _______________________________________________ > NumPy-Discussion mailing list > [email protected] > http://mail.scipy.org/mailman/listinfo/numpy-discussion >
_______________________________________________ NumPy-Discussion mailing list [email protected] http://mail.scipy.org/mailman/listinfo/numpy-discussion
