On Mon, Oct 19, 2009 at 4:36 PM, Robert Kern <robert.k...@gmail.com> wrote:
> On Mon, Oct 19, 2009 at 17:28, Charles R Harris > <charlesr.har...@gmail.com> wrote: > > > > On Mon, Oct 19, 2009 at 3:55 PM, Travis Oliphant <oliph...@enthought.com > > > > wrote: > > >> Right now, though, the patch has too many white-space only changes in > >> it. Could you submit a new patch that removes those changes? > > > > The old whitespace is hard tabs and needs to be replaced anyway. The new > > whitespace doesn't always get the indentation right, however. That file > > needs a style/whitespace cleanup. > > That's fine, but whitespace cleanup needs to be done in commits that > are separate from the functional changes. > > I agree, but it can be tricky to preserve hard tabs when your editor uses spaces and has hard tabs set to 8 spaces. That file is on my cleanup list anyway, I'll try to get to it this weekend. Chuck
_______________________________________________ NumPy-Discussion mailing list NumPy-Discussion@scipy.org http://mail.scipy.org/mailman/listinfo/numpy-discussion