On Tue, Oct 1, 2013 at 7:58 AM, Nathaniel Smith <n...@pobox.com> wrote:

> I bet the difference is:
>
> In master, nansum ultimately calls arr.sum(...), which will be
> intercepted by Series.sum.
>
> In 1.8.x, nansum ultimately calls np.add.reduce(...), which can't be
> intercepted and will return the wrong thing.
>
> AFAICT the np.add.reduce(a, ...) call could just be replaced with
> a.sum(...), but I might be missing something... surely there must have
> been some reason it was written that way in the first place?
>

No good reason, just a bit more efficient. The change for current master
was because of the change in nansum behavior for empty slices. Changing the
call to a.sum is not a problem, although I confess that it seems a bit
fragile...

<snip>

Chuck
_______________________________________________
NumPy-Discussion mailing list
NumPy-Discussion@scipy.org
http://mail.scipy.org/mailman/listinfo/numpy-discussion

Reply via email to