The deviation from docs arose a long time back and it would indeed be a breaking change to modify the behavior now. The test for Contains is definitely equality now, so much so that you can provide your own comparer!
However, I wouldn't hesitate to provide a separate constraint that uses equality and (possibly) modify the behavior for NUnit 3.0, using different syntax for identity and equality. Charlie On Wed, Sep 19, 2012 at 2:45 AM, Simone Busoli <[email protected]> wrote: > Hi Christian, that's right, I didn't spot that the docs say that Contains > would check for identity equality. > Complying to that now would indeed be a breaking change though. > > -- > You received this bug notification because you are subscribed to NUnit > Extended Testing Platform. > https://bugs.launchpad.net/bugs/1051847 > > Title: > self contained item in array causes stack overflow > > To manage notifications about this bug go to: > https://bugs.launchpad.net/nunitv2/+bug/1051847/+subscriptions -- You received this bug notification because you are a member of NUnit Developers, which is subscribed to NUnit V2. https://bugs.launchpad.net/bugs/1051847 Title: self contained item in array causes stack overflow Status in NUnit V2 Test Framework: Confirmed Bug description: using System.Collections; using System.Collections.Generic; using NUnit.Framework; [TestFixture] public class Reproduction { class SelfContainer : IEnumerable { public IEnumerator GetEnumerator() { yield return this; } } [Test] public void SelfContainedItemFoundInArray() { var item = new SelfContainer(); var items = new SelfContainer[] { new SelfContainer(), item }; // work around Assert.True(((ICollection<SelfContainer>)items).Contains(item)); // causes StackOverflowException Assert.Contains(item, items); } } Reproduced in NUnit 2.6.1 See also bug #491300 To manage notifications about this bug go to: https://bugs.launchpad.net/nunitv2/+bug/1051847/+subscriptions _______________________________________________ Mailing list: https://launchpad.net/~nunit-core Post to : [email protected] Unsubscribe : https://launchpad.net/~nunit-core More help : https://help.launchpad.net/ListHelp
