Citeren Arnaud Quette <[email protected]>:
I have received documentation about the protocol of the Zinto A UPSs by
Online USV-Systeme and wrote a driver to monitor and configure my UPS. This
is based heavily on the blazer driver,
Arjen, the blazer* author, will probably jump on this thread when he has
some spare time.
Indeed... :-)
In order to help, you should identify the differences that made you choose
this driver as a base.
I had a quick look at the patch and agree with the above. This is
almost identical to the existing blazer_ser and blazer_usb drivers.
The only things that looked different where some additional commands
and settings. This can be integrated in the existing blazer.c module
easily with the addition of a driver flag.
As it is, this patch is not acceptable to me, since it duplicates
*way* too much code. Another problem is the addition of new variables,
which immediately raises a red flag. This necessity to do this needs
to be discussed first. From the naming, it looks like we already have
something similar.
If the original poster can give me some hints on what the format of
the additional commands is (preferably by disclosing the
documentation), I'd be happy to add this to the driver (I'm not going
to extract this from the submitted code).
Best regards, Arjen
--
Please keep list traffic on the list (off-list replies will be rejected)
_______________________________________________
Nut-upsdev mailing list
[email protected]
http://lists.alioth.debian.org/cgi-bin/mailman/listinfo/nut-upsdev
