[
https://issues.apache.org/jira/browse/NUTCH-669?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12653940#action_12653940
]
Todd Lipcon commented on NUTCH-669:
-----------------------------------
I've pushed the initial commit of this rewrite/refactor to github:
http://github.com/toddlipcon/nutch/commit/5c9d99a856628c842b50b1d76f62b375f377bf95
Might be worth just reviewing it as if it were a new file rather than a diff:
http://github.com/toddlipcon/nutch/tree/5c9d99a856628c842b50b1d76f62b375f377bf95/src/java/org/apache/nutch/fetcher/Fetcher.java
Still have some more cleanup and revisions here, plus I want to test it on a
real crawl or two from our cluster. It currently passes the TestFetcher unit
test but I don't know what the coverage is on that.
I'll attach a patch here before it's ready to be comitted it so I can check off
the license grant checkbox, which I know is important for ASF.
> Consolidate code for Fetcher and Fetcher2
> -----------------------------------------
>
> Key: NUTCH-669
> URL: https://issues.apache.org/jira/browse/NUTCH-669
> Project: Nutch
> Issue Type: Improvement
> Components: fetcher
> Affects Versions: 0.9.0
> Reporter: Todd Lipcon
> Priority: Minor
>
> I'd like to consolidate a lot of the common code between Fetcher and
> Fetcher2.java.
> It seems to me like there are the following differences:
> - Fetcher relies on the Protocol to obey robots.txt and crawl delay
> settings whereas Fetcher2 implements them itself
> - Fetcher2 uses a different queueing model (queue per crawl host) to
> accomplish the per-host limiting without making the Protocol do it.
> I've begun work on this but want to check with people on the following:
> - What reason is there for Fetcher existing at all since Fetcher2 seems to be
> a superset of functionality?
> - Is it on the road map to remove the robots/delay logic from the Http
> protocol and make Fetcher2's delegation of duties the standard?
> - Any other improvements wanted for Fetcher while I am in and around the code?
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
