Sean,

This does look like a bug. Thanks for spotting it. But is there any reason to use the banned-hostname stuff anymore? The regex-urlfilter supercedes this functionality. So my proposal is to cut this code rather than fix it. Any objections?

Doug

Sean Lee wrote:
between line 240 & 250 fo Fetcher.java ,

                    //
                    // 1. Check hostname
                    //
                    String hostname = url.getHost().toLowerCase();
                    if (hostnameBans != null) {
                        for (int i = 0; i < hostnameBans.length; i++) {
                            if (hostnameBans[i].matches(hostname)) {
                                LOG.fine("Hostname banned for " + urlString);
                                handleNoFetch(fle, true);
                                *continue*;  <-------------------------
                            }
                        }
                    }




Isn't that continue meant to "continue" the outer infiniate while loop instead of that for loop? In that case, maybe a boolean var should set and checked outside that for loop.

~ Sean Lee

------------------------------------------------------------------------
Test your ‘Travel Quotient’ and get the chance to win your dream trip! <http://g.msn.com/8HMAENUS/2749??PS=> ------------------------------------------------------- This SF.Net email is sponsored by: Oracle 10g Get certified on the hottest thing ever to hit the market... Oracle 10g. Take an Oracle 10g class now, and we'll give you the exam FREE. http://ads.osdn.com/?ad_id=3149&alloc_id=8166&op=click _______________________________________________ Nutch-developers mailing list [EMAIL PROTECTED] https://lists.sourceforge.net/lists/listinfo/nutch-developers


-------------------------------------------------------
This SF.Net email is sponsored by: Oracle 10g
Get certified on the hottest thing ever to hit the market... Oracle 10g. Take an Oracle 10g class now, and we'll give you the exam FREE.
http://ads.osdn.com/?ad_id=3149&alloc_id=8166&op=click
_______________________________________________
Nutch-developers mailing list
[EMAIL PROTECTED]
https://lists.sourceforge.net/lists/listinfo/nutch-developers

Reply via email to