Doug Cutting wrote:
Andy Hedges wrote:
Please let me know what you think of my patch which can be found here:
http://www.hedges.net/nutch/
A few quick comments:
I don't see where you close the response body stream. Shouldn't this be done, i.e., to close the socket?
Sloppy of me, it's fixed now.
I don't see where the headers Properties is populated. Did I miss something?
Oversight :(
We use Http.TIMEOUT for both the connect and read timeout, but you only seem to specify the connect timeout.
This is also fixed
We use Http.BUFFER_SIZE to determine kernel read/write size. So this should be set in params as the sendBufferSize and recieveBufferSize, no?
When you say kernel what are you refering to? I believe but I need to verify that the data is read off the wire as controlled by the obtained inputstream. I might be wrong I need to determine this by sifting though some of the HttpClient code - unless you already know the answer.
Doug
Revised patch can be found here:
http://www.hedges.net/nutch/
Thanks, Andy
-------------------------------------------------------
This SF.Net email sponsored by Black Hat Briefings & Training.
Attend Black Hat Briefings & Training, Las Vegas July 24-29 - digital self defense, top technical experts, no vendor pitches, unmatched networking opportunities. Visit www.blackhat.com
_______________________________________________
Nutch-developers mailing list
[EMAIL PROTECTED]
https://lists.sourceforge.net/lists/listinfo/nutch-developers
-------------------------------------------------------
This SF.Net email sponsored by Black Hat Briefings & Training.
Attend Black Hat Briefings & Training, Las Vegas July 24-29 - digital self defense, top technical experts, no vendor pitches, unmatched networking opportunities. Visit www.blackhat.com
_______________________________________________
Nutch-developers mailing list
[EMAIL PROTECTED]
https://lists.sourceforge.net/lists/listinfo/nutch-developers
