Dawid Weiss wrote:
Eclipse shows a good few warnings
in the present codebase. They are usually minor things like malformed
JavaDocs, unused variables and such.
One can presumably disable such minor warnings in Eclipse. Arguably the
bug is that Eclipse warns about such things by default, rather than in a
'pedantic' mode.
Does it make sense to fix them? I
can correct at least some of them when I go through the code, but such
patches are tedious to review and need to be applied promptly to avoid
conflicts.
With folks using a variety of tools to edit their code, some such
warnings are inevitable. Fixing these can clutter patches whose intent
is to fix something else. One way to deal with these is to ocassionally
make a big commit which fixes all of them across the whole project
(according to a particular warning system, anyway) and makes no other
changes.
One caution: we have run into problems where includes were removed
because a tool said they were unused, but they were required for the
Javadoc. So code-analysis tools are not infallible!
Alternately, we could try to integrate some tool into the ant build
process that checks for unused variables, etc. Then we could make
"warning-free" a requirement for commits.
PMD looks like a useful such tool:
http://pmd.sourceforge.net/ant-task.html
I would not be opposed to integrating PMD or something similar into
Nutch's build.xml. What do others think? Any volunteers?
Doug
-------------------------------------------------------
This SF.Net email is sponsored by xPML, a groundbreaking scripting language
that extends applications into web and mobile media. Attend the live webcast
and join the prime developer group breaking into this new coding territory!
http://sel.as-us.falkag.net/sel?cmd=lnk&kid=110944&bid=241720&dat=121642
_______________________________________________
Nutch-developers mailing list
[email protected]
https://lists.sourceforge.net/lists/listinfo/nutch-developers
