On Wed, Apr 13, 2022 at 11:37:06AM -0700, Ben Widawsky wrote: > Save some characters and directly check decoder type rather than port > type. There's no need to check if the port is an endpoint port since we > already know the decoder, after alloc, has a specified type. > > Signed-off-by: Ben Widawsky <[email protected]> > --- > drivers/cxl/core/hdm.c | 2 +- > drivers/cxl/core/port.c | 2 +- > drivers/cxl/cxl.h | 1 + > 3 files changed, 3 insertions(+), 2 deletions(-) > > diff --git a/drivers/cxl/core/hdm.c b/drivers/cxl/core/hdm.c > index 0e89a7a932d4..bfc8ee876278 100644 > --- a/drivers/cxl/core/hdm.c > +++ b/drivers/cxl/core/hdm.c > @@ -197,7 +197,7 @@ static int init_hdm_decoder(struct cxl_port *port, struct > cxl_decoder *cxld, > else > cxld->target_type = CXL_DECODER_ACCELERATOR; > > - if (is_cxl_endpoint(to_cxl_port(cxld->dev.parent))) > + if (is_endpoint_decoder(&cxld->dev)) > return 0; > > target_list.value = > diff --git a/drivers/cxl/core/port.c b/drivers/cxl/core/port.c > index 2ab1ba4499b3..74c8e47bf915 100644 > --- a/drivers/cxl/core/port.c > +++ b/drivers/cxl/core/port.c > @@ -272,7 +272,7 @@ static const struct device_type cxl_decoder_root_type = { > .groups = cxl_decoder_root_attribute_groups, > }; > > -static bool is_endpoint_decoder(struct device *dev) > +bool is_endpoint_decoder(struct device *dev) > { > return dev->type == &cxl_decoder_endpoint_type; > } > diff --git a/drivers/cxl/cxl.h b/drivers/cxl/cxl.h > index 990b6670222e..5102491e8d13 100644 > --- a/drivers/cxl/cxl.h > +++ b/drivers/cxl/cxl.h > @@ -340,6 +340,7 @@ struct cxl_dport *cxl_find_dport_by_dev(struct cxl_port > *port, > > struct cxl_decoder *to_cxl_decoder(struct device *dev); > bool is_root_decoder(struct device *dev); > +bool is_endpoint_decoder(struct device *dev); > bool is_cxl_decoder(struct device *dev); > struct cxl_decoder *cxl_root_decoder_alloc(struct cxl_port *port, > unsigned int nr_targets); > -- > 2.35.1 > >
Looks good. Reviewed by: Adam Manzanares <[email protected]>
