On Tue, 2022-05-31 at 17:09 -0700, Dan Williams wrote: > From: Chris Ye <[email protected]> > > nvdimm_clear_badblocks_region() validates badblock clearing requests > against the span of the region, however it compares the inclusive > badblock request range to the exclusive region range. Fix up the > off-by-one error. > > Fixes: 23f498448362 ("libnvdimm: rework region badblocks clearing") > Cc: <[email protected]> > Signed-off-by: Chris Ye <[email protected]> > Signed-off-by: Dan Williams <[email protected]> > --- > drivers/nvdimm/bus.c | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-)
Good find! Looks good to me, Reviewed-by: Vishal Verma <[email protected]> > > diff --git a/drivers/nvdimm/bus.c b/drivers/nvdimm/bus.c > index 7b0d1443217a..5db16857b80e 100644 > --- a/drivers/nvdimm/bus.c > +++ b/drivers/nvdimm/bus.c > @@ -182,8 +182,8 @@ static int nvdimm_clear_badblocks_region(struct > device *dev, void *data) > ndr_end = nd_region->ndr_start + nd_region->ndr_size - 1; > > /* make sure we are in the region */ > - if (ctx->phys < nd_region->ndr_start > - || (ctx->phys + ctx->cleared) > ndr_end) > + if (ctx->phys < nd_region->ndr_start || > + (ctx->phys + ctx->cleared - 1) > ndr_end) > return 0; > > sector = (ctx->phys - nd_region->ndr_start) / 512; > >
