> We used to initialize the provider_data manually after
> nvdimm_pemm_region_create(). This seems to be racy if the flush is
> issued before the initialization of provider_data. Fixing this by
> initialize the provider_data through nd_region_desc to make sure the
> provider_data is ready after the pmem is created.
>
> Fixes 6e84200c0a29 ("virtio-pmem: Add virtio pmem driver")
> Signed-off-by: Jason Wang <[email protected]>
> ---
> drivers/nvdimm/virtio_pmem.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/nvdimm/virtio_pmem.c b/drivers/nvdimm/virtio_pmem.c
> index 995b6cdc67ed..48f8327d0431 100644
> --- a/drivers/nvdimm/virtio_pmem.c
> +++ b/drivers/nvdimm/virtio_pmem.c
> @@ -81,6 +81,7 @@ static int virtio_pmem_probe(struct virtio_device *vdev)
> ndr_desc.res = &res;
> ndr_desc.numa_node = nid;
> ndr_desc.flush = async_pmem_flush;
> + ndr_desc.provider_data = vdev;
> set_bit(ND_REGION_PAGEMAP, &ndr_desc.flags);
> set_bit(ND_REGION_ASYNC, &ndr_desc.flags);
> nd_region = nvdimm_pmem_region_create(vpmem->nvdimm_bus, &ndr_desc);
> @@ -89,7 +90,6 @@ static int virtio_pmem_probe(struct virtio_device *vdev)
> err = -ENXIO;
> goto out_nd;
> }
> - nd_region->provider_data =
> dev_to_virtio(nd_region->dev.parent->parent);
> return 0;
> out_nd:
> nvdimm_bus_unregister(vpmem->nvdimm_bus);
Thank you for adding me.
The patch seems correct to me. Will test this as well.
Acked-by: Pankaj Gupta <[email protected]>
Thanks,
Pankaj
