On Thu, Jun 23, 2022 at 07:45:43PM -0700, Dan Williams wrote: > This helper was only used to identify the object type for lockdep > purposes. Now that lockdep support is done with explicit lock classes, > this helper can be dropped. > > Signed-off-by: Dan Williams <[email protected]> > --- > drivers/cxl/core/port.c | 6 ------ > drivers/cxl/cxl.h | 1 - > 2 files changed, 7 deletions(-) > > diff --git a/drivers/cxl/core/port.c b/drivers/cxl/core/port.c > index b51eb41aa839..13c321afe076 100644 > --- a/drivers/cxl/core/port.c > +++ b/drivers/cxl/core/port.c > @@ -271,12 +271,6 @@ bool is_root_decoder(struct device *dev) > } > EXPORT_SYMBOL_NS_GPL(is_root_decoder, CXL); > > -bool is_cxl_decoder(struct device *dev) > -{ > - return dev->type && dev->type->release == cxl_decoder_release; > -} > -EXPORT_SYMBOL_NS_GPL(is_cxl_decoder, CXL); > - > struct cxl_decoder *to_cxl_decoder(struct device *dev) > { > if (dev_WARN_ONCE(dev, dev->type->release != cxl_decoder_release, > diff --git a/drivers/cxl/cxl.h b/drivers/cxl/cxl.h > index 35ce17872fc1..6e08fe8cc0fe 100644 > --- a/drivers/cxl/cxl.h > +++ b/drivers/cxl/cxl.h > @@ -337,7 +337,6 @@ struct cxl_dport *cxl_find_dport_by_dev(struct cxl_port > *port, > struct cxl_decoder *to_cxl_decoder(struct device *dev); > bool is_root_decoder(struct device *dev); > bool is_endpoint_decoder(struct device *dev); > -bool is_cxl_decoder(struct device *dev); > struct cxl_decoder *cxl_root_decoder_alloc(struct cxl_port *port, > unsigned int nr_targets); > struct cxl_decoder *cxl_switch_decoder_alloc(struct cxl_port *port, > >
Looks good. Reviewed by: Adam Manzanares <[email protected]>
