Verma, Vishal L wrote:
> On Wed, 2022-07-13 at 07:47 -0700, Dan Williams wrote:
> > Verma, Vishal L wrote:
> > > On Tue, 2022-07-12 at 12:08 -0700, Dan Williams wrote:
> > > > Exercise the fundamental region provisioning sysfs mechanisms of 
> > > > discovering
> > > > available DPA capacity, allocating DPA to a region, and programming HDM
> > > > decoders.
> > > > 
> > > > Signed-off-by: Dan Williams <[email protected]>
> > > > ---
> > > >  test/cxl-region-create.sh |  122 
> > > > +++++++++++++++++++++++++++++++++++++++++++++
> > > >  test/meson.build          |    2 +
> > > >  2 files changed, 124 insertions(+)
> > > >  create mode 100644 test/cxl-region-create.sh
> > > 
> > > Since this isn't actually creating a region, should this be named
> > > cxl-reserve-dpa.sh ?
> > 
> > The test goes all the way to the point of registering a new region with
> > libnvdimm, so it is region creation.
> > 
> > > Alternatively - I guess this test could just be extended to do actual
> > > region creation once that is available in cxl-cli?
> > 
> > I was thinking that's a separate test that moves from just one hardcoded
> > pmem region via sysfs toggling to permuting all the possible cxl_test
> > region configurations across both modes via 'cxl create-region'. One is
> > a sysfs smoke test the other is a create-region unit test.
> 
> Ah okay makes sense - maybe this should be called cxl-region-sysfs to
> reflect that?

Sure, sounds good.

Reply via email to