Hi Dan,

Thank you!

This patch is not necessary, but we have a concern that might some customer would like to keep "no_deepflush=0" option. From BTT perspective, we still would like to control independently.

BR,

Dennis Wu

On 7/13/22 09:10, Dan Williams wrote:
Dennis.Wu wrote:
Reason: we can have a global control of deepflush in the nfit module
by "no_deepflush" param. In the case of "no_deepflush=0", we still
need control data deepflush or not by the NVDIMM_NO_DEEPFLUSH flag.
In the BTT, the btt information block(btt_sb) will use deepflush.
Other like the data blocks(512B or 4KB),4 bytes btt_map and 16 bytes
bflog will not use the deepflush. so that, during the runtime, no
deepflush will be called in the BTT.
Why do you need this in the BTT driver when deepflush is disabled
globally for all regions?

ADR only applies at global visibility of stores, so the pmem_wmb() is
still necessary.

Reply via email to