Hi, > Hi Tarun, > > Sorry for the delay in reviewing these. From a quick look, it looks > like you're adding read-modify-write functionality to the write- > infoblock command - is that correct? > > I think the original intent of these commands was, purely as a > debug/test aid, that the user would be responsible for reading the > namespace if needed, and using that as a basis for writing the > infoblockl if an RMW operation is desired. However for the most part, > write-infoblock just creates infoblocks out of thin air, and > optionally > writes it to a namepspace. I'm not sure adding a read-modify-write > here > is really that useful, unless you have a specific use case for this > sort of thing?
>From the man page, it is not clear that, non-provided args values will get updated without user concern, and It comes as surprise to user as user didnt intend to change that. For Example, If user only want to change the value of uuid of a namespace infoblock, So They perform write-infoblock with particular uuid but didnt pass align value which they intended not to change but write-infoblock changes it to default value. This patch, read-modify-write takes care of other arguments which are not passed for the concerned namespace as part of write-infoblock by retaining the values of them. Other patch of this series, takes advantage of the above read-modify-write functionality and implement write-infoblock for sector/BTT namespaces. Which currently allows only uuid and parent_uuid updates.
